WMainMenuBar: Simplify and Fix PDF detection#22
Merged
ronso0 merged 2 commits intoMar 30, 2021
Conversation
5 tasks
Holzhaus
force-pushed
the
keyboard-shortcut-pdf
branch
from
76f433d to
c608dce
Compare
Holzhaus
force-pushed
the
keyboard-shortcut-pdf
branch
from
c608dce to
fb801a9
Compare
ronso0
reviewed
Mar 30, 2021
| @@ -0,0 +1 @@ | |||
| #cmakedefine MIXXX_INSTALL_DOCDIR_RELATIVE_TO_DATADIR "@MIXXX_INSTALL_DOCDIR_RELATIVE_TO_DATADIR@" | |||
Owner
There was a problem hiding this comment.
interesting, I wasn't aware that we can use cmake vars in the actual project code.
somehow I considered those two entirely separate 'things'
Author
There was a problem hiding this comment.
We can use them via configure_file or target_compile_definitions. The #cmakedefine is like a regular #define except that it maps to undef if the variable is not set.
Owner
|
Thank you, works nicely! admittedly I was just too lazy to separate the doc detection..thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the PDF detection code for WMainMenuBar easier to grasp and also fixes the issue that local PDFs are not detected when running mixxx from the build dir without an installation.